Page 1 of 1

Can not change icones for switch Lightning 6

Posted: Thursday 16 April 2020 10:54
by xavierlp
Hello all

I need your help on this case : (may be a bug)

On my switch with type lightning 1, I can change the icone.
bureau Light 1.png
bureau Light 1.png (10.84 KiB) Viewed 720 times
bureau Light 2.png
bureau Light 2.png (14.07 KiB) Viewed 720 times

On switches with lignthin 6 : no options....
entree Light 1.png
entree Light 1.png (12 KiB) Viewed 720 times
I couldn't find anytging about that. Is it a bug ?

I'm using 2020.1 on RPI4

Thanks a lot for any ideas.

Re: Can not change icones for switch Lightning 6

Posted: Thursday 16 April 2020 10:55
by xavierlp
entree Light 2 (2).png
entree Light 2 (2).png (11.79 KiB) Viewed 719 times

Re: Can not change icones for switch Lightning 6

Posted: Thursday 16 April 2020 11:05
by waaren
xavierlp wrote: Thursday 16 April 2020 10:54 I need your help on this case : (may be a bug)
On switches with lignthin 6 : no options....
Thanks a lot for any ideas.
Can you please try and test by changing line 8 of <domoticz dir>/www/app/devices/deviceFactory.js from

Code: Select all

                return ['Light/Switch', 'Lighting 1', 'Lighting 2', 'Lighting 5','Color Switch'].includes(device.Type) &&
to

Code: Select all

               return ['Light/Switch', 'Lighting 1', 'Lighting 2', 'Lighting 5','Lighting 6','Color Switch'].includes(device.Type) &&
and clear browser cache and app cache (different things)
Maybe also a domoticz restart is needed.

If successful I will create a PR for this

Re: Can not change icones for switch Lightning 6

Posted: Thursday 16 April 2020 12:24
by xavierlp
Yesssss

It works : Thanks a lot :D

Re: Can not change icones for switch Lightning 6

Posted: Sunday 19 April 2020 22:55
by xavierlp
Dear Waaren,

If you can also add "Home Confort", It could be great.

I could test it, and it works also

thanks again

Re: Can not change icones for switch Lightning 6

Posted: Monday 20 April 2020 0:17
by waaren
xavierlp wrote: Sunday 19 April 2020 22:55 If you can also add "Home Confort", It could be great.
Can you please explain what this is and attach a screenshot of the current icon ? I have no idea what this is.

Re: Can not change icones for switch Lightning 6

Posted: Monday 20 April 2020 22:19
by xavierlp
Image


Envoyé de mon iPhone en utilisant Tapatalk

Re: Can not change icones for switch Lightning 6

Posted: Monday 20 April 2020 22:21
by xavierlp
Image
Hello it is a device for a lamp

By défaut only the lamp icone is available

I could update the line 8 to have this :


Envoyé de mon iPhone en utilisant Tapatalk

Re: Can not change icones for switch Lightning 6

Posted: Monday 20 April 2020 22:22
by xavierlp
Image


Envoyé de mon iPhone en utilisant Tapatalk

Re: Can not change icones for switch Lightning 6

Posted: Monday 20 April 2020 22:47
by waaren
xavierlp wrote: Monday 20 April 2020 22:22 A picture says more .....
OK clear. I created Pull Request #4089 . If @gizmocuz is OK it will be merged in one of the next Beta's

Re: Can not change icones for switch Lightning 6

Posted: Monday 20 April 2020 22:58
by xavierlp
Thanks again


Envoyé de mon iPhone en utilisant Tapatalk