Ack

Moderator: leecollings

NewFolk
Posts: 39
Joined: Wednesday 02 September 2015 11:47
Target OS: Raspberry Pi / ODroid
Domoticz version:
Contact:

Re: Ack

Post by NewFolk »

BTW
I found interesting thread on Mysensors forum about ACK functionality on GW side
http://forum.mysensors.org/topic/2189/s ... ack-failed
User avatar
gizmocuz
Posts: 2521
Joined: Thursday 11 July 2013 18:59
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Location: Top of the world
Contact:

Re: Ack

Post by gizmocuz »

Done, Domoticz now supports sending ACK messages to the Nodes (Set commands (like switching on/off))
Domoticz now also verifies if the ACK is received, if not sending a switch command will result in an error

Tested (by pulling out my test light switch node), and working !

ACK timeout is 1200ms, but my test results are acknowledged in 100ms, so its very fast.
From the above like, 500ms seems already way to much in RF world

Beta version #3448
Quality outlives Quantity!
NewFolk
Posts: 39
Joined: Wednesday 02 September 2015 11:47
Target OS: Raspberry Pi / ODroid
Domoticz version:
Contact:

Re: Ack

Post by NewFolk »

Great ! Will test in a few days!
Thank you!
Yury
Posts: 4
Joined: Sunday 13 September 2015 16:07
Target OS: Raspberry Pi / ODroid
Domoticz version:
Contact:

Re: Ack

Post by Yury »

gizmocuz wrote:Done, Domoticz now supports sending ACK messages to the Nodes (Set commands (like switching on/off))
Great, thank you very much!

One little issue I found so far. If there is a repeater used between the node and the gateway, somehow domoticz accept ack from repeater even if the node is off line.
The node is physically very far from the gateway so there is noway it can communicate directly.

Otherwise, it works perfectly.

Repeater node uses code from repeater node example.
Mysensors 1.5
Raspberry PI-2
Domoticz updated to #3448
NewFolk
Posts: 39
Joined: Wednesday 02 September 2015 11:47
Target OS: Raspberry Pi / ODroid
Domoticz version:
Contact:

Re: Ack

Post by NewFolk »

Hello, I tested today with repeater node. But test was very quick without serial monitor.

And I do not confirm the problem.
ACK in Dominicz works good with and without repeater node.
User avatar
gizmocuz
Posts: 2521
Joined: Thursday 11 July 2013 18:59
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Location: Top of the world
Contact:

Re: Ack

Post by gizmocuz »

Thanks for the feedback.

Indeed i would expect it also to work correct with repeater mode.

You can take a look at the vera code, and you see no difference between that and this implementation

https://github.com/mysensors/Vera
Quality outlives Quantity!
Yury
Posts: 4
Joined: Sunday 13 September 2015 16:07
Target OS: Raspberry Pi / ODroid
Domoticz version:
Contact:

Re: Ack

Post by Yury »

Hello,

Everything is OK. It was my mistake.
I did not do clear EPROM properly... so I ended up with the repeater and the node with the same nodeID which I hard coded. That is why repeater ACK was accepted as node ACK.

All work great.
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

Hi,
I am trying to use a secured node (that require signed messages) and it seem the ack timeout is too short for the signing handshaking to finish in time.
Is there a way of increasing/specifying the acceptable timeout for an ACK to arrive?
It would also be great if that timeout was then configurable together with the per-node ack setting.
User avatar
gizmocuz
Posts: 2521
Joined: Thursday 11 July 2013 18:59
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Location: Top of the world
Contact:

Re: Ack

Post by gizmocuz »

that you should ask on the mysensors forum
Quality outlives Quantity!
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

gizmocuz wrote:that you should ask on the mysensors forum
Hm, ok. But my question has nothing to do with the MySensors library, it is very domoticz specific. Do you have some topic on the MySensors forum this should be posted in if you still think it should be discussed in that context?

Sent from my D5803 using Tapatalk
User avatar
Domosapiens
Posts: 232
Joined: Wednesday 20 August 2014 12:08
Target OS: Windows
Domoticz version: V3.5981
Location: NL
Contact:

Re: Ack

Post by Domosapiens »

Useless information detection:
Sent from my D5803 using Tapatalk
Who cares?

Domosapiens
Win Vista&7; 1#Aeon Z-Stick S2; 1#Aeotec Z-Sick Gen5, 6#Fib.FGBS001; 24#DS18B20; 8#Everspr.AN158-2; 3#Philio PAN04; 1#Philio PAN06, 1#YouLess El; 1#Fib.FGWPE; 1#ZME_RC2; 2#FAK_ZWS230, 2#Quib.ZMNHCDx, 1#Quib.ZMNHDD1, 7#EM6555
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

Domosapiens wrote:Useless information detection:
Sent from my D5803 using Tapatalk
Who cares?

Domosapiens
Automatic signature from my app. Problem?

Sent from my D5803 using Tapatalk
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

gizmocuz wrote:that you should ask on the mysensors forum
@gizmocuz
Ok, I have made a post in the MySensors forum as well. Same question, in the domoticz thread there. We can continue the discussion there if you prefer.

Sent from my D5803 using Tapatalk
User avatar
gizmocuz
Posts: 2521
Joined: Thursday 11 July 2013 18:59
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Location: Top of the world
Contact:

Re: Ack

Post by gizmocuz »

Anticimex wrote:
gizmocuz wrote:that you should ask on the mysensors forum
@gizmocuz
Ok, I have made a post in the MySensors forum as well. Same question, in the domoticz thread there. We can continue the discussion there if you prefer.
is it possible you can to your tapatalk settings and disable the signature?

If using ack (which i think should be default for switches), normally an ack is received ver fast
domoticz is waiting up to 1200ms (1.2 seconds)

see 'MySensorsBase::SendNodeSetCommand'

1.2 seconds should be long enough ?
Quality outlives Quantity!
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

It is not as fast for secured nodes because a nonce needs to be exchanged beforehand. So no, 1.2 seconds is not enough in this case. Also, depending on the number of repeaters in the mesh network, delay could be arbitrary so I really think a timeout needs to be configurable.
User avatar
gizmocuz
Posts: 2521
Joined: Thursday 11 July 2013 18:59
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Location: Top of the world
Contact:

Re: Ack

Post by gizmocuz »

what is the maximum delay you expect ?
as i remember, i have read somewhere normally it was arround 100ms (for normal sensors)
Quality outlives Quantity!
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

gizmocuz wrote:what is the maximum delay you expect ?
as i remember, i have read somewhere normally it was arround 100ms (for normal sensors)
Well, the nonce timeout default setting in the MySensors library I believe is 5s so I think it should be at least that (although any MySensors user can reduce/increase it at their leisure). Generally, having a long timeout should not be a big issue except when the node is not operating normally. Ack should arrive within 2s for a secured node, but, again, it depends on network topology.
I am on the beta channel and I will happily evaluate any changes you publish.
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

Hello again,
any update on this? It is really important for MySensors compatibility that controllers can handle secured nodes as well. And in this case, the issue also affects relayed nodes who take longer time to respond based on the number of hops in the mesh network.
I am not asking for this to be fixed quickly, only that it is acknowledged and added to some roadmap of improvements. Preferably with a configurable timeout (so that domoticz sources don't need to change in the future if the timeout needs to be adjusted again).
User avatar
Ferpando
Posts: 30
Joined: Friday 23 October 2015 9:45
Target OS: NAS (Synology & others)
Domoticz version:
Location: Spain
Contact:

Re: Ack

Post by Ferpando »

Hi,

I made some changes to the VERA code some time ago because I have a node with several switches which takes long to execute, so if I sent 2 or more commands at the same time some got lost.

What this does for VERA is store sent messages in a queue at VERA's side and only clear the buffer as Ack's are received.
If an Ack is not received, VERA will try to send missed commands again after a certain amount of time, for the number of times defined. Also commands are not sent all at once but with a predefined interval from each other, so the chances of missing one is reduced.

You can read about it here:

http://forum.mysensors.org/topic/131/sc ... or-gateway

and maybe add this functionality to Domoticz.
Anticimex
Posts: 14
Joined: Sunday 29 November 2015 18:36
Target OS: Raspberry Pi / ODroid
Domoticz version: beta
Contact:

Re: Ack

Post by Anticimex »

I notice that when I enable Ack for a node, Domoticz sends commands to that node twice. Is this intentional? If I disable ACK in Domoticz for the node (the child representing my actuator) Domoticz just sends one command as intended. But with ACK "on" it sends the command two times in rapid succession.
It does not happen every time. Just approx. every second attempt.
Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests