letsencrypt - implementation of X9.42 Diffie Hellman encoding

[meal]

Hello,

I have implemented the Diffie Hellman encoding in the SSL certificat generation using Cerbot.

From a functional standpoint the SSL access to domoticz is working properly.

However I get a Domoticz error "missing SSL DH parameters from file ..." each time I reboot domoticz.

I made an assessment of the source code and in server.cpp discovered that domoticz checks the presence of "BEGIN DH PARAMETERS" in the certificat.

In my case the certificate contains "BEGIN X9.42 DH PARAMETERS" instead of "BEGIN DH PARAMETERS" which causes the error at boot time.

Would it be possible to have the defect fixed for the next release of Domoticz allowing both presence of "BEGIN DH PARAMETERS" and "BEGIN X9.42 DH PARAMETERS" in the certificat ?

Many thanks for the reply.
BR

[meal]

Hello,

To complement my previous post the defect appears in the 2 following methods of the sslserver class
void ssl_server::init_connection() and in void ssl_server::reinit_connection() {

BR

[kiddigital]

Can you create an issue on Github for this problem?

Please also add instructions on how to generate your type of certificate so it can be tested locally.

[meal]

Hello

Issue 5079 created in GitHub

BR