what am I doing wrong?? I can't get my head round it!!

[chrisfraser05]

I have a very simple script that works to ping my phone then turn on and off a virtual device.

This was no problem.

What I then went on to do was add a user variable, and try to make a counter.

I want to reset the counter to 0 when it pings correctly, and each time it fails +1 until it hits 3, where it turns off the virtual device.

As the script runs every minute this gives a bit of a debounce.

Can anyone tell me what I've done wrong here, and why it won't work?

Thanks

Code: Select all

commandArray = {}
 
local device
local chrisvar

 device = 'Phone Chris'
 chrisvar = (uservariable['chrisVar'])

ping_success=os.execute('ping 192.168.1.72 -n 1 -w 100>nul')

 if ping_success then
 --  print("ping success - " ..device)
   commandArray[device]='On'
   chrisvar = 0
 else
     
   print("ping fail - " ..device)
   chrisvar = chrisvar + 1
   
  if (chrisvar == 3) then
   commandArray[device]='Off'	
   end
 end
 
return commandArray

[chrisfraser05]

This is the working version without the couter

Code: Select all

commandArray = {}
 
local device

 device = 'Phone Chris'
 
ping_success=os.execute('ping 192.168.1.72 -n 1 -w 100>nul')

 if ping_success then
--   print("ping success - " ..device)
   commandArray[device]='On'
 else
   print("ping fail - " ..device)
   commandArray[device]='Off'	
 end
 
return commandArray

[Nautilus]

change this:

Code: Select all

chrisvar = (uservariable['chrisVar'])

to this

Code: Select all

chrisvar = tonumber(uservariables['chrisVar'])

Also, you need to update the new uservariable value:

Code: Select all

commandArray['Variable:chrisVar'] = tostring(chrisvar)

The check if chrisvar == 3 should be before "chrisvar = chrisvar + 1" if you want it to be three fails before changing the switch to off. Also consider adding conditions not to update the variable when not needed (= value 0 or 3 ?).

[chrisfraser05]

Thanks very much for your help.

I'd tried most other things but I wasn't aware I needed to update the uservariable again.
That makes sense.

So rather than declaring that chrisvar is the same is the same as the user variable at the start I'm actually transferring the value across but need to transfer it back again after!

Cheers