Domoticz

I created for both devices Python plugins: and Please let me know your comments.

What is the difference with this plugin that seems to do the same: https://github.com/Eraser3/HomeWizard-Wifi-p1-plugin ?


Edit: Is see, these plugins are for the separate Homewizard kWh meters and not for the regular Smart meter with a P1 Homewizard dongle....

Perhaps make 1 plugin out of it with a configuration setting if it is for a 1 Phase or 3 Phase meter? Seems easier to maintain.
Perhaps the plugin can figure it out itself if it is connected to a 1 or 3 Phase meter based on the received info?

The structure of both is the same and there is quit a lot of common code, but one module would make it more complicated.

But indeed, for new users, 1 plugin with a selection if you are using 1F or 3F would be easier
(they only have to download 1 plugin)

I just happened to have both devices, but what about the users that only have one of these devices.

Ideally the plugin should find out what type of meter the user has installed. When that is too difficult to discover from the response of the meter you can add a plugin configuration option to set the meter type by the user.

The user should know if it has a 1 phase or 3 phase meter installed so there could be a plugin parameter mode-x that states the meter phases (1 or 3). And based on that parameter the plugin creates and updates Domoticz devices for a 1 or 3 phase meter.

But if that is too difficult to implement it is fine to have 2 different plugins.... You asked for suggestions

Additional, what are settings mode 3 and 4 for? There is no explanation in the readme. And it seems not logical settings. So perhaps remove them (or use 1 mode to use it as 1/3 phase type )

You are right, I copied most of the code from the P1 device, that has these these Mode 3 and 4. The code is there still as comment, but it should be made clear in the README.