Domoticz

philchillbill wrote: ↑Saturday 02 May 2020 17:55 I used to have the following script in use a few years ago (it worked). I just tried to re-use it in Domoticz 2020.2 and the log shows an error
Error: EventSystem: in updateCounters: [string "commandArray = {}..."]:3: bad argument #3 to 'format' (number has no integer representation)

which I do not understand. Any pointers to what I'm doing wrong?

commandArray = {}
local function updatenum(dev, value1)
    local cmd = string.format("%d|0|%d", otherdevices_idx[dev], math.floor(value1))
    table.insert (commandArray, { ['UpdateDevice'] = cmd } )
end
if (devicechanged['Quooker'] == 'On') then
	print("otherdevices['Quooker Top-Ups'] : " .. tostring(otherdevices['Quooker Top-Ups']))
	updatenum('Quooker Top-Ups', tonumber(otherdevices['Quooker Top-Ups']) + 1)
end
return commandArray

philchillbill wrote: ↑Saturday 02 May 2020 18:46 Thanks @waaren, that did the trick !

Any idea how I could reset that counter every day after midnight?

waaren wrote: ↑Saturday 02 May 2020 21:21

philchillbill wrote: ↑Saturday 02 May 2020 18:46 Thanks @waaren, that did the trick !

Any idea how I could reset that counter every day after midnight?

I would do that using a dzVents script. What is the type / subType of the device ?

Spoiler: show

Code: Select all

		{
			"AddjMulti" : 1.0,
			"AddjMulti2" : 1.0,
			"AddjValue" : 27000.0,
			"AddjValue2" : 0.0,
			"BatteryLevel" : 255,
			"Counter" : "44388 Firings",
			"CounterToday" : "17311 Firings",
			"CustomImage" : 0,
			"Data" : "44388 Firings",
			"Description" : "",
			"Favorite" : 0,
			"HardwareID" : 9,
			"HardwareName" : "Dummy",
			"HardwareType" : "Dummy (Does nothing, use for virtual switches only)",
			"HardwareTypeVal" : 15,
			"HaveTimeout" : false,
			"ID" : "82751",
			"LastUpdate" : "2020-05-02 22:41:40",
			"Name" : "Quooker Top-Ups",
			"Notifications" : "false",
			"PlanID" : "0",
			"PlanIDs" : 
			[
				0
			],
			"Protected" : false,
			"ShowNotifications" : true,
			"SignalLevel" : "-",
			"SubType" : "Counter Incremental",
			"SwitchTypeVal" : 3,
			"Timers" : "false",
			"Type" : "General",
			"TypeImg" : "counter",
			"Unit" : 1,
			"Used" : 1,
			"ValueQuantity" : "Firings",
			"ValueUnits" : "Firings",
			"XOffset" : "0",
			"YOffset" : "0",
			"idx" : "751"
		}

philchillbill wrote: ↑Saturday 02 May 2020 23:03 Any idea how I could reset that counter every day after midnight?

return 
{
    on = 
    { 
        devices =  
        { 
            'Quooker'  
        }
    }, 

    logging = 
    {
        level = domoticz.LOG_DEBUG,
        marker = 'Quooker',
    },
    
    execute = function(dz, item)
        local topsUp = dz.devices('Quooker Top-Ups')
        
        if item.active then 
            topsUp.incrementCounter(1)
        end
    end
}

philchillbill wrote: ↑Sunday 03 May 2020 8:06 The thing is that the GUI counter does not reset at midnight any more, like it use to do in the past (total/today).

• Is domoticz active at midnight?
• do you see anything suspicious in the log just after midnight?
• did you recently checked your database integrity?
• what do you see in the database tables Meter and Meter_Calendar for this device?

philchillbill wrote: ↑Sunday 03 May 2020 22:34 Yes, the machine Domoticz runs on never sleeps. There's noting strange in the logs at midnight either. I have not checked the DB integrity so I will do that. WIth your modified Lua code, I just noticed the following entry in the log:

Code: Select all

2020-05-03 22:28:33.259 Status: LUA: otherdevices['Quooker Top-Ups'] : 18446744073709550265
2020-05-03 22:28:33.259 Error: EventSystem: in updateCounters: [string "commandArray = {}..."]:3: bad argument #3 to 'format' (number has no integer representation)

So the value is a crazy-large wannabe-integer: 18446744073709550265.

Is there any way that the device name with dash in it (Quooker Top-Ups) is risky in Lua?

philchillbill wrote: ↑Monday 04 May 2020 14:35 I did an integrity check on the db and the result was ok. Just for kicks, I deleted the counter device and created a new one with a different idx and so no history. The counter seems to increment exponentially when the underlying on/off switch used in the Lua script switches from off to on. First it counted 1 (correct), then 3, now 6. Looks like a Domoticz issue (I'm on stable 2020.2).

waaren wrote: ↑Monday 04 May 2020 17:00

philchillbill wrote: ↑Monday 04 May 2020 14:35 I did an integrity check on the db and the result was ok. Just for kicks, I deleted the counter device and created a new one with a different idx and so no history. The counter seems to increment exponentially when the underlying on/off switch used in the Lua script switches from off to on. First it counted 1 (correct), then 3, now 6. Looks like a Domoticz issue (I'm on stable 2020.2).

Isn't this because you are using an incremental counter? You add the current total + 1 to the current total. (the behavior of incremental counter changed in V4.10102)
That's why I add only 1 in the dzVents script.