Page 22 of 49

Re: Dashticz - Module - Garbage collector

Posted: Wednesday 10 January 2018 17:12
by aiolos
Moosjes wrote: Wednesday 10 January 2018 16:59
Moosjes wrote: Wednesday 10 January 2018 14:32 I have added the Garbage calander of Veldhoven to my Dashticz but all I get in the dashboard is 'Laden...'
I found the sollution to my own problem. I had selected the company 'Veldhoven' instead of 'veldhoven' (mind the capital V). After changing this it still did not work.

After I changed the company to 'ical' it worked :D
But then you're using config['garbage_icalurl'] and not config['garbage_zipcode'] and config['garbage_housenumber']? Zipcode and housenumber are used by the veldhoven parser.

Re: Dashticz - Module - Garbage collector

Posted: Wednesday 10 January 2018 19:07
by AndreFR
robgeerts wrote: Monday 08 January 2018 21:30 Hmm indeed, we cannot use the afvalkalender.container-beheer.nl website.
But I've read on the website of Rotterdam that you should be able to use mijnafvalwijzer.
Try choosing this in dashticz-settings and enter your zipcode and house number.
Hi Rob/aiolos,
I’ve requested to have our city to be included to the ‘mijnafvalwijzer.nl’ website, it works if I use another ‘postcode’....

Re: Dashticz - Module - Garbage collector

Posted: Thursday 11 January 2018 22:25
by jake
htilburgs wrote:When using config['garbage_icon_use_colors'] = false; in your config.js, no icon is showed.
When checking I think the problem is:

Code: Select all

<img class="trashcan" src="img/kliko.png" style="opacity: 1;">
While it should be img/trashcan/kliko.png
garbage.js needs an update. Indeed kliko.png has moved, but not yet in the code.

instead of "img/kliko.png", it should be "img/garbage/kliko.png"

Re: Dashticz - Module - Garbage collector

Posted: Thursday 11 January 2018 22:32
by EdwinK
jake wrote: Thursday 11 January 2018 22:25
htilburgs wrote:When using config['garbage_icon_use_colors'] = false; in your config.js, no icon is showed.
When checking I think the problem is:

Code: Select all

<img class="trashcan" src="img/kliko.png" style="opacity: 1;">
While it should be img/trashcan/kliko.png
garbage.js needs an update. Indeed kliko.png has moved, but not yet in the code.

instead of "img/kliko.png", it should be "img/garbage/kliko.png"
Was just going to post about this :)

Re: Dashticz - Module - Garbage collector

Posted: Friday 12 January 2018 13:53
by aiolos
Thanks for noticing. I made a PR to fix it.

Re: Dashticz - Module - Garbage collector

Posted: Friday 12 January 2018 15:39
by geertvercamer
There is a problem with the 'ophaalkalender' method for Belgium.

In the function mapGarbageType() a mapping is done from 'blue' to 'papier', however that should be 'PMD (line 350)'. 'brown' should map to 'papier'

In my region we only have 'pmd', 'restafval' and 'p-k', but there are more in ie. Gent:
- GFT: green
- Glas: yellow
- Grof huisvuil afroep: purple
- Kerstboom: lightgreen
- P-K: brown
- PMD: blue
- Restafval: grey

and it may be nice to have a config/setting variable for the date format.

Thanks.

Re: Dashticz - Module - Garbage collector

Posted: Friday 12 January 2018 15:47
by EdwinK
aiolos wrote: Friday 12 January 2018 13:53 Thanks for noticing. I made a PR to fix it.

I still miss a 'thank you' button :)

So, thank you

Re: Dashticz - Module - Garbage collector

Posted: Saturday 13 January 2018 17:35
by robgeerts
It's merged :)

Re: Dashticz - Module - Garbage collector

Posted: Saturday 13 January 2018 20:12
by EdwinK
Thanks again

Re: Dashticz - Module - Garbage collector

Posted: Saturday 13 January 2018 21:16
by maceddy
Any chance you will implement 'Area Reiniging'?

http://www.areareiniging.nl/home/bewone ... -digitaal/

It shows a Calendar in some sort of frame and there is a possibility to download iCal, but I can not get it to work..
You may use my ZIP and house number (request per DM please :-) ) if you plan on testing it.

Thanks!

Re: Dashticz - Module - Garbage collector

Posted: Sunday 14 January 2018 23:36
by Regdul
is there any change to add "de friese meren' garbage calendar? same as maceddy, i cant get it to work. there is an option for Ical

https://dfm.afvalalert.nl/#

thanks!

Re: Dashticz - Module - Garbage collector

Posted: Monday 15 January 2018 11:57
by pkrabben
Hi All,

De Garbage collector is not working anymore in Almere
can you add http://afvalportaal2.2go-mobile.com/mod ... /calendar/

Thanks In advance

Re: Dashticz - Module - Garbage collector

Posted: Tuesday 16 January 2018 0:44
by aiolos
pkrabben wrote: Monday 15 January 2018 11:57 Hi All,

De Garbage collector is not working anymore in Almere
can you add http://afvalportaal2.2go-mobile.com/mod ... /calendar/

Thanks In advance
maceddy wrote: Saturday 13 January 2018 21:16 Any chance you will implement 'Area Reiniging'?

http://www.areareiniging.nl/home/bewone ... -digitaal/

It shows a Calendar in some sort of frame and there is a possibility to download iCal, but I can not get it to work..
You may use my ZIP and house number (request per DM please :-) ) if you plan on testing it.

Thanks!
Both these garbage collection calendars are added. See this PR

The garbage company configuration is:
config['garbage_company'] = 'area';
and
config['garbage_company'] = 'almere';
Please note that for Almere the GFT & Rest are combined, they show up as a green bin, this can of course be changed with selecting another bin for this type of garbage.

Both calendars use the same (or a very alike) API as 'Twente Milieu'. I expect more calendars are based on this API, which makes it very easy to add them.

I tested this with a random address in Emmen and Almere, please let me know if you experience any difficulties (after a merge of course, it is not in there yet)

I saw the 'De Friese Meren' request. Looks do-able, but I could not implement it in the short time I had available right now. I will look into it later.

Re: Dashticz - Module - Garbage collector

Posted: Tuesday 16 January 2018 11:09
by pkrabben
Thanks Almere is working

Re: Dashticz - Module - Garbage collector

Posted: Tuesday 16 January 2018 18:25
by EdwinK
Is it right that the colors of the trashbin's dont change anymore?

Re: Dashticz - Module - Garbage collector

Posted: Tuesday 16 January 2018 23:58
by aiolos
Regdul wrote: Sunday 14 January 2018 23:36 is there any change to add "de friese meren' garbage calendar? same as maceddy, i cant get it to work. there is an option for Ical

https://dfm.afvalalert.nl/#

thanks!
In this PR the support for this garbage calendar is added.
Configuration:
config['garbage_company'] = 'afvalalert';
It is very likely this company also works for other regions than 'De Friese Meren'
EdwinK wrote: Tuesday 16 January 2018 18:25 Is it right that the colors of the trashbin's dont change anymore?
It does with my config (which is pretty standard for development) For various garbage companies and addresses I saw different colours of bins.

Re: Dashticz - Module - Garbage collector

Posted: Wednesday 17 January 2018 9:20
by robgeerts
PR is merged! :)

Re: Dashticz - Module - Garbage collector

Posted: Wednesday 17 January 2018 10:01
by EdwinK
aiolos wrote: Tuesday 16 January 2018 23:58
EdwinK wrote: Tuesday 16 January 2018 18:25 Is it right that the colors of the trashbin's dont change anymore?
It does with my config (which is pretty standard for development) For various garbage companies and addresses I saw different colours of bins.

Then I've to look through all the settings (again).

Re: Dashticz - Module - Garbage collector

Posted: Wednesday 17 January 2018 10:29
by EdwinK
Looks there is something more happening.

As seen on https://www.mijnafvalwijzer.nl/nl/3161LH/27/ today is 'grof vuil' and on Friday we have 'rest'. But on dashticz it shows all the dates as 'rest'. Only 'gft' is changing colors in the text.

Part of config.js

Code: Select all

config['garbage_company'] = 'mijnafvalwijzer';
config['garbage_icalurl'] = '0';
config['garbage_calendar_id'] = '';
config['garbage_zipcode'] = '3161LH';
config['garbage_street'] = 'Jonkerhof';
config['garbage_housenumber'] = '27';
config['garbage_housenumberadd'] = '';
config['garbage_maxitems'] = 2;
config['garbage_width'] = '6';
config['garbage_hideicon'] = '0';
config['garbage_icon_use_colors'] = 1;
config['garbage_use_colors'] = 1;
config['garbage_use_names'] = 1;
config['garbage_use_cors_prefix'] = '0';

...

//Afval
config['garbage'] = {
    gft: 	{kliko: 'green', 	code: '#375b23', name: 'GFT'},
//  pmd: 	{kliko: 'orange', 	code: '#db5518', name: 'PMD'},
    rest: 	{kliko: 'grey', 	code: '#5e5d5c', name: 'Restafval'},
    papier: {kliko: 'blue', 	code: '#153477', name: 'Papier'},
//  kca: 	{kliko: 'red', 		code: '#b21807', name: 'Chemisch afval'},
    brown: 	{kliko: 'brown', 	code: '#7c3607', name: 'Grof Vuil'},
//  black: 	{kliko: 'black', 	code: '#000000', name: 'Zwart'},
};


Re: Dashticz - Module - Garbage collector

Posted: Wednesday 17 January 2018 13:48
by geertvercamer
Maybe this has also something to do with this function mapGarbageType()?