Page 3 of 20

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:03
by Snowtiger
fees wrote:I'm not sure whether go combine temperature, humidity and barometer into one or two devices or make three separate devices for that. Not sure what is best practice/most common/most desired.
My opinion - combine them like Weather Underground does - Temp + Humidity + Baro is a known device type and subtype, if someone wants to separate them - it is always possible to write a lua script which checks change of the device and split them up into separate values ;)

Re: RE: Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:05
by EldigoR
Snowtiger wrote:
fees wrote:I'm not sure whether go combine temperature, humidity and barometer into one or two devices or make three separate devices for that. Not sure what is best practice/most common/most desired.
My opinion - combine them like Weather Underground does - Temp + Humidity + Baro is a known device type and subtype, if someone wants to separate them - it is always possible to write a lua script which checks change of the device and split them up into separate values ;)
Yes combine them Image

Verstuurd vanaf mijn D5803 met Tapatalk

Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:11
by Snowtiger
ffes wrote:Thanks you all for spotting the bug in getWindChill(). You are right, it should be self.temperature. When I coded it, it was too cold to find this error :?

I've committed this fix to the repo. Do "git pull"
Gitt pull fails - msg -

Code: Select all

error: Your local changes to the following files would be overwritten by merge:
        buienradar.py
Please, commit your changes or stash them before you can merge.
Aborting
my bad - changed the file to correct the error myself :?

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:21
by fkok
Snowtiger wrote:
ffes wrote:Thanks you all for spotting the bug in getWindChill(). You are right, it should be self.temperature. When I coded it, it was too cold to find this error :?

I've committed this fix to the repo. Do "git pull"
Gitt pull fails - msg -

Code: Select all

error: Your local changes to the following files would be overwritten by merge:
        buienradar.py
Please, commit your changes or stash them before you can merge.
Aborting
my bad - changed the file to correct the error myself :?
I had the same, because i changed the file myself. first do a git reset --hard, en then a git pull.

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:29
by Snowtiger
fkok wrote:I had the same, because i changed the file myself. first do a git reset --hard, en then a git pull.
I know ;) thx anyway

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:33
by EldigoR
ffes wrote: I also added the code to add the wind device.
Nice work with the Wind device!
I think it would beter to have Wind+Temp+Chill as Weather underground also has :)

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:40
by Snowtiger
EldigoR wrote:
ffes wrote: I also added the code to add the wind device.
Nice work with the Wind device!
I think it would beter to have Wind+Temp+Chill as Weather underground also has :)
I am up with that ;)
Second there is also a strange value in it, see the image ImageMaybe it has to be rounded?

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 20:57
by ffes
I just update the github repository. The wind is now a "Wind+Temp+Chill" device and the rounding is improved.

Working on specifying the interval yourself, but for some reason I can't get the "default" value to work as expected.

Re: RE: Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:09
by Snowtiger
ffes wrote:I just update the github repository. The wind is now a "Wind+Temp+Chill" device and the rounding is improved .
Top Image

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:15
by Brutus
I don't understand why you would like to have alle the values in one sensor like WU does. I think the sensors of WU are a mess, I see the temperature on three sensors at the same time and the "Wind" sensor is linked to a seperated temperature sensor. Changing the name for one of the two sensors will change the other one to. Not logical to me.

So for me I hope it gets separated so its clean.

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:17
by schulpr
Brutus wrote:I don't understand why you would like to have alle the values in one sensor like WU does. I think the sensors of WU are a mess, I see the temperature on three sensors at the same time and the "Wind" sensor is linked to a seperated temperature sensor. Changing the name for one of the two sensors will change the other one to. Not logical to me.

So for me I hope it gets separated so its clean.
I give my vote to Brutus. Combined sensors are a mess.

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:19
by fkok
Brutus wrote:I don't understand why you would like to have alle the values in one sensor like WU does. I think the sensors of WU are a mess, I see the temperature on three sensors at the same time and the "Wind" sensor is linked to a seperated temperature sensor. Changing the name for one of the two sensors will change the other one to. Not logical to me.

So for me I hope it gets separated so its clean.
I Agree!!!

Re: RE: Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:20
by Snowtiger
Brutus wrote:I don't understand why you would like to have alle the values in one sensor like WU does. I think the sensors of WU are a mess, I see the temperature on three sensors at the same time and the "Wind" sensor is linked to a seperated temperature sensor. Changing the name for one of the two sensors will change the other one to. Not logical to me.

So for me I hope it gets separated so its clean.
You can separate it yourself - why 8 or ten values added by one hardware device - to much device sensors which you do not use
And after all , its also a matter of taste ...

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:23
by ffes
I think I can make that optional (two combined devices or 5 separate devices). What would make everybody happy!

I would make my life more difficult because the combined temp+hum+baro wants other values for BAR_FOR then the plain Barometer device: https://www.domoticz.com/wiki/Domoticz_ ... #Barometer

Re: RE: Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:34
by Snowtiger
ffes wrote:I think I can make that optional (two combined devices or 5 separate devices). What would make everybody happy!

I would make my life more difficult because the combined temp+hum+baro wants other values for BAR_FOR then the plain Barometer device: https://www.domoticz.com/wiki/Domoticz_ ... #Barometer
What you suits best - I can live with n devices ;) After all you do not have to comply to WU devices - you are setting up Buienalarm devices :)

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:40
by EldigoR
ffes wrote:I think I can make that optional (two combined devices or 5 separate devices). What would make everybody happy!

I would make my life more difficult because the combined temp+hum+baro wants other values for BAR_FOR then the plain Barometer device: https://www.domoticz.com/wiki/Domoticz_ ... #Barometer
Keep the temp+hum+baro and make a option for serparate wind or combined devices ;)

Re: RE: Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 21:49
by Brutus
Snowtiger wrote:
Brutus wrote:I don't understand why you would like to have all the values in one sensor like WU does. I think the sensors of WU are a mess, I see the temperature on three sensors at the same time and the "Wind" sensor is linked to a separated temperature sensor. Changing the name for one of the two sensors will change the other one to. Not logical to me.

So for me I hope it gets separated so its clean.
You can separate it yourself - why 8 or ten values added by one hardware device - to much device sensors which you do not use
And after all , its also a matter of taste ...
I agree with you that it's a personal taste and we don't need to have a lot of unnecessary sensors in our device lists ;)
But I think it's logic that you combine the sensors that are related to each other. For example:

* Temperature
* Wind speed - Wind Direction - Wind Chill - Wind Speed Gust.
* Barometer - Barometer Forecast
* etc

For me I think the separation of the linked temperature sensors is a good way to start ;)

With the latest update we have a separated Temperature sensor, Wind sensor with again a linked temperature sensor you can't delete.

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 22:16
by Snowtiger
Brutus wrote:But I think it's logic that you combine the sensors that are related to each other. For example:

* Temperature
* Wind speed - Wind Direction - Wind Chill - Wind Speed Gust.
* Barometer - Barometer Forecast
* etc

For me I think the separation of the linked temperature sensors is a good way to start ;)

With the latest update we have a separated Temperature sensor, Wind sensor with again a linked temperature sensor you can't delete.
I agree with the logic part - but you have to be sure there is a Device present in Domoticz that can take the values you want.

And for separation of values - keep in mind that wind chill is also a temperature value, the "wgr800 windsensor" earlier used today does not incorporate this value ;)

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 22:29
by Brutus
Snowtiger wrote:
Brutus wrote:But I think it's logic that you combine the sensors that are related to each other. For example:

* Temperature
* Wind speed - Wind Direction - Wind Chill - Wind Speed Gust.
* Barometer - Barometer Forecast
* etc

For me I think the separation of the linked temperature sensors is a good way to start ;)

With the latest update we have a separated Temperature sensor, Wind sensor with again a linked temperature sensor you can't delete.
I agree with the logic part - but you have to be sure there is a Device present in Domoticz that can take the values you want.

And for separation of values - keep in mind that wind chill is also a temperature value, the "wgr800 windsensor" earlier used today does not incorporate this value ;)
So these separate Wind / Temperature sensors are "linked" in Domoticz and can't be separated?

The Wind chill value isn't that important I think. But that's personal. ;)

Re: Buienradar Weather Lookup Plugin

Posted: Wednesday 15 February 2017 22:34
by gerardvs
If someone is counting votes, i 'm with Brutus and vote for separate devices. Combining and hiding unused sensors is imho easier than splitting.

That said, great plugin and keep up the good work!

--Gerard