Domoticz

jimphelps wrote:Hi,
i've got a problem with Time:

Code: Select all

Error: EventSystem: in /home/pi/domoticz/scripts/lua/script_time_main.lua: /home/pi/domoticz/scripts/lua/event_helpers.lua:179: attempt to call global 'getDayOfWeek' (a nil value)

It happens at domoticz start and every minute when a script like "schedule fish pond pump.lua" (based on day of week) is active:

Code: Select all

return {
	active = true,
	on = {
		['timer'] = {
			'at 8:30 on mon,tue,wed,thu,fri'
		}
	},
	...
	

Other "every minute" scripts are working well...
Does somone have an idea?
thanks
Jim

dannybloe wrote:

jimphelps wrote:Hi,
i've got a problem with Time:

Code: Select all

Error: EventSystem: in /home/pi/domoticz/scripts/lua/script_time_main.lua: /home/pi/domoticz/scripts/lua/event_helpers.lua:179: attempt to call global 'getDayOfWeek' (a nil value)

It happens at domoticz start and every minute when a script like "schedule fish pond pump.lua" (based on day of week) is active:

Code: Select all

return {
	active = true,
	on = {
		['timer'] = {
			'at 8:30 on mon,tue,wed,thu,fri'
		}
	},
	...
	

Other "every minute" scripts are working well...
Does somone have an idea?
thanks
Jim

It was indeed a bug that I already fixed in the other branches. I hope to release them this weekend. In the mean time what you can do is open the file event-helpers.lua and move the function getDayOfWeek near the bottom of the file to above the function at line 179. That should fix it.

Eduard wrote:I have some issues with scenes, groups & virtual text devices.

The calls that won't work with scenes & groups:

Code: Select all

domoticz.devices['Scene1'].name
domoticz.devices['Group1'].name

It gives an error

Code: Select all

attempt to index field 'Scene1' (a nil value)
attempt to index field 'Group1' (a nil value)

And with virtual text devices when i try to change the text:

Code: Select all

domoticz.devices['Logging'].updateText('Hello!')
domoticz.devices['Logging'].update('Hello!')

It gives an error

Code: Select all

attempt to index field 'Logging' (a nil value)

How can i get scene/groupnames and how can i update virtual text devices?

dannybloe wrote: What I can do is use the http data for this. The only downside to this is that this data is fetched by default every 30 minutes (see the settings file) so it may not be there (yet) when you just created such a device (scene, group, text) (of course you can easily create a dummy switch with a dzVents script that forces to fetch this data on switch click using domoticz.fetchHttpDomoticzData().

Eduard wrote:@dannybloe
Saw your code (in createMissingHTTPDevices) on the dev-branch (did not test is yet) but do you keep the idx'es from devices & scene/groups apart? Because in Domoticz they can have the same idx!

	domoticz.devices[]
	domoticz.variables[]
	domoticz.scenes[]
	domoticz.groups[]

Eduard wrote:@dannybloe
What exactly do you have to fetch via the httprequest? I know my way a little bit in the Domoticz-code, so maybe we can expose the missing data via the 'normal' way.
I think it is possible to expose the missing scene/group info for example to dzVents by adding code to Domoticz...

	local function extendDevicesWithHTTPData()
		local httpData = readHttpDomoticzData()

		if (httpData) then
			for i, httpDevice in pairs(httpData.result) do
				if (self.devices[tonumber(httpDevice['idx'])]) then
					local device = self.devices[tonumber(httpDevice['idx'])]
					device.addAttribute('batteryLevel', httpDevice.BatteryLevel)
					device.addAttribute('signalLevel', httpDevice.SignalLevel)
					device.addAttribute('deviceSubType', httpDevice.SubType)
					device.addAttribute('deviceType', httpDevice.Type)
					device.addAttribute('hardwareName', httpDevice.HardwareName)
					device.addAttribute('hardwareType', httpDevice.HardwareType)
					device.addAttribute('hardwareId', httpDevice.HardwareID)
					device.addAttribute('hardwareTypeVal', httpDevice.HardwareTypeVal)
					device.addAttribute('switchType', httpDevice.SwitchType)
					device.addAttribute('switchTypeValue', httpDevice.SwitchTypeVal)

					if (device.deviceType == 'Heating' and device.deviceSubType == 'Zone') then
						device.addAttribute('setPoint', tonumber(device.rawData[2]))
						device.addAttribute('heatingMode', device.rawData[3])
					end

					if (device.deviceType ==  'Lux' and device.deviceSubType == 'Lux') then
						device.addAttribute('lux', tonumber(device.rawData[1]))
					end

					if (device.deviceType ==  'General' and device.deviceSubType == 'kWh') then
						device.addAttribute('WhTotal', tonumber(device.rawData[2]))
						device.addAttribute('WhToday', tonumber(device.rawData[1]))
					end
					if (device.deviceType ==  'P1 Smart Meter' and device.deviceSubType == 'Energy') then
						device.addAttribute('WActual', tonumber(device.rawData[5]))
					end

					if (device.deviceType == 'Thermostat' and device.deviceSubType == 'SetPoint') then
						device.addAttribute('setPoint', tonumber(device.rawData[1]))
					end

					if (device.deviceSubType == 'Text') then
						device.addAttribute('text', httpDevice.Data) -- could be old because it may not be fetched
					end
				end
			end
		end
	end
	

dannybloe wrote:Of course, it would be awesome that you use the code that generates the json that is sent through json.htm?type=devices&displayhidden=1&filter=all&used=true and have that generate a Lua table with exactly the same data. You can see the result when you open devices.lua after dzVents downloaded and converted this data. But that may be too much to ask.

dannybloe wrote:Sounds great.

Eduard wrote:

dannybloe wrote:Sounds great.

@dannybloe
I've created a patch for the missing states of textlog-devices & several virtual devices. I also added a new LUA-table "otherdevices_scenesgroups" with all the Scenes/Groups with their status.

Are you able to test this patch with dzVents before i make a pull-request to merge it with the master-branch? You can find it at https://github.com/EddyK69/domoticz/tree/lua_expose

Thanx

Eduard wrote:

dannybloe wrote:Sounds great.

@dannybloe
I've created a patch for the missing states of textlog-devices & several virtual devices. I also added a new LUA-table "otherdevices_scenesgroups" with all the Scenes/Groups with their status.

Are you able to test this patch with dzVents before i make a pull-request to merge it with the master-branch? You can find it at https://github.com/EddyK69/domoticz/tree/lua_expose

Thanx

dannybloe wrote:How do we get to the id of a scene or a group? It isn't part of the otherdevices_idx table but I do need it for completeness. I can still get that from the http data or you should create a table like otherdevices_groupsandscenes_idx or something like that.

dannybloe wrote:And.. I want to have scenes and groups split so I can create domoticz.scenes[<name>/<id>] and domoticz.groups[<name>/<id>]. So I need a way to distinguish these two. If they are all in one table then I still cannot make that distinction without using the http data.

      {
         "Data" : "Mixed",
         "Description" : "",
         "Favorite" : 0,
         "LastUpdate" : "2016-03-17 12:35:42",
         "Name" : "Scene1",
         "PlanID" : "",
         "PlanIDs" : [ 0 ],
         "Protected" : false,
         "Status" : "Mixed",
         "Type" : "Scene",
         "TypeImg" : "scene",
         "UsedByCamera" : false,
         "XOffset" : 0,
         "YOffset" : 0,
         "idx" : "1"
      },
      {
         "Data" : "Off",
         "Description" : "",
         "Favorite" : 0,
         "LastUpdate" : "2016-02-06 16:57:47",
         "Name" : "Group1",
         "PlanID" : "",
         "PlanIDs" : [ 0 ],
         "Protected" : false,
         "Status" : "Off",
         "Type" : "Group",
         "TypeImg" : "group",
         "UsedByCamera" : false,
         "XOffset" : 0,
         "YOffset" : 0,
         "idx" : "2"
      }