Domoticz

solarboy wrote: ↑Sunday 22 May 2022 20:06 Perhaps in a future update our concerns will be silently resolved...

If some of you could test if everything works as expected, that would be nice. In attachment to this post you can find the 3 modified files.

config.schema.json - Should be placed in /homebridge/node_modules/homebridge-edomoticz/
constants.js and domoticz_accessory.js - Should be placed in /homebridge/node_modules/homebridge-edomoticz/lib

Don't forget to make a backup of your old files first!!!

PS: Feel free to make adjustments or propose improvements if you have any knowledge of javascript. Also report any bugs with as much details as you can. If it works as expected, we can always create a pull request, in the hope it will be accepted (but I honestly don't know how that all works).

Marci wrote: ↑Wednesday 19 October 2022 20:15 Once folks are happy with the proposed changes, see https://docs.github.com/en/get-started/ ... o-projects for how to create a fork, make your modifications, then submit a pull request.

Long story short: I don’t have any blinds, so can’t test anything to do with blinds.

Stepdes wrote: ↑Wednesday 19 October 2022 20:47 Tested and works for me, thanks for this work arround.

Stephan

ksacca wrote: ↑Wednesday 19 October 2022 16:37 There has been a lot of discussion lately about the changes to the behavior of blinds in the latest beta version. Inverted blinds don't exist anymore, they have now been replaced by options where you can choose to invert the state (Open/Close) or position (slider). Also the command to open and close blinds are now Open and Close instead of On and Off (even though On and Off still works, but the other way around).

As some of you might have noticed, I posted a quick fix on https://github.com/domoticz/domoticz/issues/5371 for blinds which works as long as you don't invert the state or position. I've been looking at the code today to see if a solution can be found (as I don't see a lot of activity on the hombebridge-edomoticz github page).

I was able to get all blind types working for the new blind behavior, as well as the old ones. I didn't change anything for venetian blinds, as I don't have any to test (but I suppose it should work). There is also a new type of blinds in domoticz (Blinds + Stop) that was previously not supported. They are also blinds with position, but just have a stop button. Those blind types are automatically created when using MQTT Autodiscovery, so I added support for them too (just not the stop button, as that's not supported by homebridge as far as I know).

When using the new type of blinds, the Open or Close command will be sent. For older ones, it's still On or Off. The State and Position will be automatically recalculated to be reflected correctly in the home app.

I had to add an option the homebridge-edomoticz settings where you have to set if you use legacy blinds or not (this was the easiest way without having to create a new function). It should be left to 0 when using a recent beta, or set to 1 if using an older version.

homebridge-settings.JPG

If some of you could test if everything works as expected, that would be nice. In attachment to this post you can find the 3 modified files.

config.schema.json - Should be placed in /homebridge/node_modules/homebridge-edomoticz/
constants.js and domoticz_accessory.js - Should be placed in /homebridge/node_modules/homebridge-edomoticz/lib

Don't forget to make a backup of your old files first!!!

PS: Feel free to make adjustments or propose improvements if you have any knowledge of javascript. Also report any bugs with as much details as you can. If it works as expected, we can always create a pull request, in the hope it will be accepted (but I honestly don't know how that all works).

ksacca wrote: ↑Friday 21 October 2022 10:20 I forked homebridge-edomoticz and made all code changes. It is available on https://github.com/ksacca/homebridge-edomoticz.
You can see the changes to the code in each commit.

If you would like to test, you should be able to replace the files using the following commands (replace your-path-to-homebridge-edomoticz by the directory where your edomoticz plugin is installed). A backup of your old file will be made, so you can always revert the changes.

Code: Select all

cd <your-path-to-homebridge-edomoticz>
sudo wget --backups=1 https://raw.githubusercontent.com/ksacca/homebridge-edomoticz/master/config.schema.json
cd lib
sudo wget --backups=1 https://raw.githubusercontent.com/ksacca/homebridge-edomoticz/master/lib/constants.js
sudo wget --backups=1 https://raw.githubusercontent.com/ksacca/homebridge-edomoticz/master/lib/domoticz_accessory.js

Don't forget to restart homebridge once the files have been replaced.

/usr/lib/node_modules/homebridge-edomoticz/

tjabas wrote: ↑Saturday 26 November 2022 18:25 Hi!

i have some plugins that i use to control my philips tv, the only way i got working was to install a plugin in homebridge, i tried install it in domoticz directly but i didnt get it to work.
so my question is if its possible to get domoticz to control these swithes that i have made to control my tv in homebridge?
today i use this edomoticz plugin to get all my switches from domoticz into homebridge, but is it possible to do it the other way?

Marci wrote: ↑Wednesday 19 October 2022 20:15 Once folks are happy with the proposed changes, see https://docs.github.com/en/get-started/ ... o-projects for how to create a fork, make your modifications, then submit a pull request.

Long story short: I don’t have any blinds, so can’t test anything to do with blinds.

JonyBCN wrote: ↑Saturday 26 November 2022 19:33

tjabas wrote: ↑Saturday 26 November 2022 18:25 Hi!

i have some plugins that i use to control my philips tv, the only way i got working was to install a plugin in homebridge, i tried install it in domoticz directly but i didnt get it to work.
so my question is if its possible to get domoticz to control these swithes that i have made to control my tv in homebridge?
today i use this edomoticz plugin to get all my switches from domoticz into homebridge, but is it possible to do it the other way?

For simple functions involving only button presses you can create dummy buttons in domoticz. These will be displayed in homebridge and through automations in the home app you can link them. I use it for a couple of plugs, but I think doing it with a TV can be cumbersome and impractical. But for things like turning on and off it can be a practical solution.

tjabas wrote: ↑Saturday 26 November 2022 19:45 thanks for the quick reply, i have looked everywhere in homebridge but i cant find out how to link the button/swithes together in homebridge

JonyBCN wrote: ↑Saturday 26 November 2022 19:50

tjabas wrote: ↑Saturday 26 November 2022 19:45 thanks for the quick reply, i have looked everywhere in homebridge but i cant find out how to link the button/swithes together in homebridge

It is not a link, it is an automation directly in the Home app. Something like this: "if Philips TV switch is on" then "Phlipis Dummy switch is on".
You must do it both for on and off. It's cumbersome. It works for me for a plug in the bathroom and another that controls a camera, but for something more complex I don't know if it's worth it.

JonyBCN wrote: ↑Saturday 26 November 2022 19:35

Marci wrote: ↑Wednesday 19 October 2022 20:15 Once folks are happy with the proposed changes, see https://docs.github.com/en/get-started/ ... o-projects for how to create a fork, make your modifications, then submit a pull request.

Long story short: I don’t have any blinds, so can’t test anything to do with blinds.

Only partially related: any chance to add flood detectors to the plugin? Smoke detectors and their notifications work very well and seeing flood detectors as switches is a bit of a waste.